From bf754c79d6e30a6fa36046d8f8abc6c9eced0151 Mon Sep 17 00:00:00 2001 From: Nathan McRae Date: Mon, 26 May 2025 21:50:45 -0700 Subject: [PATCH] Update crontab call --- .../numbersstation/LinuxScheduler.java | 23 ++----------------- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/src/main/java/name/nathanmcrae/numbersstation/LinuxScheduler.java b/src/main/java/name/nathanmcrae/numbersstation/LinuxScheduler.java index bb657da..9bf3ff3 100644 --- a/src/main/java/name/nathanmcrae/numbersstation/LinuxScheduler.java +++ b/src/main/java/name/nathanmcrae/numbersstation/LinuxScheduler.java @@ -27,8 +27,7 @@ public class LinuxScheduler { try { String taskName = "numbers-station-main_" + settings.getName(); - // TODO: assume it's on the PATH - Process listProcess = new ProcessBuilder("/usr/bin/crontab", "-l").start(); + Process listProcess = new ProcessBuilder("crontab", "-l").start(); if (!listProcess.waitFor(5, TimeUnit.SECONDS)) { String message = "Failed to query " + taskName + " task: process timed out"; logger.log(Level.SEVERE, message); @@ -69,8 +68,7 @@ public class LinuxScheduler { String newCrontab = sb.toString(); - // TODO: assume it's on the PATH - Process addProcess = new ProcessBuilder("/usr/bin/crontab", "-").start(); + Process addProcess = new ProcessBuilder("crontab", "-").start(); Writer w = new OutputStreamWriter(addProcess.getOutputStream(), "UTF-8"); System.out.println(newCrontab); w.write(newCrontab); @@ -94,23 +92,6 @@ public class LinuxScheduler { return Results.failure(message); } - // Path cronDPath = Paths.get("/etc/cron.d"); - // if (!Files.exists(cronDPath)) { - // String message = "/etc/cron.d does not exist, cannot create cron entry. Select 'Manage schedule externally' and set up scheduling as desired."; - // logger.log(Level.SEVERE, message); - // return Results.failure(message); - // } - - // Path cronPath = cronDPath.resolve(settings.safeName()); - - // try { - // Files.write(cronPath, cronEntry(settings).getBytes(StandardCharsets.UTF_8)); - // } catch (Exception e) { - // String message = "Failed to write cron file at '" + cronPath.toString() + "'"; - // logger.log(Level.SEVERE, message, e); - // return Results.failure(message); - // } - return Results.success(true); }